Hi Andy,
Thanks for looking through my patch. I have a couple of follow-up
questions about your feedback:
On 2/2/22 13:33, Andy Shevchenko wrote:
+ ret = PTR_ERR(pwmled->pwm);
+ dev_err(&pdev->dev, "unable to request PWM: %d\n", ret);
+ fwnode_handle_put(fwnode);
+ goto destroy_mutex;
fwnode_handle_put();
return dev_err_probe(...);
This would skip the destruction of the mutex and releasing of mcnode.
Isn't that problematic? The same goes for all of your comments of this kind.
+destroy_mutex:
+ mutex_destroy(&priv->lock);
Wrong ordering here and in ->remove().
Don't mix devm_* with non-devm_* calls.
What do you mean by this?
Best regards,
Sven
