v1: Initial send v2: Remove variant 1 from source v3: Changes requested by Andy Shevchenko added. Thanks for reviewing - Removing OF dependency - Add missing includes - Use device_property_read_u32() instead of fwnode_property_read_u32() - Use one liner function pattern <test> ? <value-true> : <value-false> - Remove switch case call for intensity color selection use BIT() instead - Remove not needed fwnode_handle_put() in ktd200xx_probe_dt() function - Use dev_get_drvdata() instead of i2c_get_clientdata() function call - Use sysfs_emit() function call - Use kstrtobool() function call - Remove not needed comma after last array element - Use dev_err_probe() instead of dev_error() in driver probe function - Do not use dev_group registration function set .dev_groups directly into ktd20xx_driver struct. v4: Changes requested by Andy Shevchenko. Thanks again for your review - Fix Author indentation - Reduce logging noise - Use 'if' standard pattern - Use set_bit function to make code cleaner - Use meaningful jump labels - Updating the logging output to better match the source code - Remove duplicate dev pointer usage. This is not necessary as the information can be used directly from the client structure - Do not hide return value from kstrbool function - Do not use mutex_destroy function in devm mananged structs Florian Eckert (2): leds: ktd20xx: Extension of the KTD20xx family of LED drivers from Kinetic dt: bindings: KTD20xx: Introduce the ktd20xx family of RGB drivers .../bindings/leds/leds-ktd20xx.yaml | 130 ++++ MAINTAINERS | 7 + drivers/leds/Kconfig | 12 + drivers/leds/Makefile | 1 + drivers/leds/leds-ktd20xx.c | 582 ++++++++++++++++++ 5 files changed, 732 insertions(+) create mode 100644 Documentation/devicetree/bindings/leds/leds-ktd20xx.yaml create mode 100644 drivers/leds/leds-ktd20xx.c -- 2.20.1