Re: [PATCH v3] leds: pca9532: Make pca9532_destroy_devices() return void

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon 2022-01-10 08:23:17, Uwe Kleine-König wrote:
> On Fri, Oct 22, 2021 at 12:17:07PM +0200, Uwe Kleine-König wrote:
> > Up to now pca9532_destroy_devices() returns always zero because it's
> > always called with data != NULL. Remove the never-taken error path and
> > make it return void which makes it easier to see in the callers that
> > there is no error to handle.
> > 
> > Also the return value of i2c remove callbacks is ignored anyway.
> > 
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> 
> Ping. This patch is part of an effort to make the i2c remove callback a
> void function, too. Are there any concerns, or plans to pick up this
> patch?

It looks like a simple cleanup with no effect outside of the
driver. Am I wrong?

Best regards,
								Pavel
-- 
http://www.livejournal.com/~pavelmachek

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux