On Wed 2021-12-15 21:53:56, Hans de Goede wrote:
> Hi,
>
> On 12/15/21 21:18, Pavel Machek wrote:
> > On Mon 2021-12-13 13:05:00, Henning Schild wrote:
> >> This driver adds initial support for several devices from Siemens. It is
> >> based on a platform driver introduced in an earlier commit.
> >>
> >> One of the supported machines has GPIO connected LEDs, here we poke GPIO
> >> memory directly because pinctrl does not come up.
> >>
> >> Signed-off-by: Henning Schild <henning.schild@xxxxxxxxxxx>
> >
> > Acked-by: Pavel Machek <pavel@xxxxxx>
>
> I see that this patch #includes linux/platform_data/x86/simatic-ipc-base.h
> which gets added by patch 1/4.
>
> Pavel, can I take this patch upstream through the pdx86 tree (with you Ack
> added)? Or shall I prepare an immutable branch with patch 1 for you to
> merge ?
Yes, you can.
> >> +
> >> +static struct simatic_ipc_led simatic_ipc_leds_io[] = {
> >> + {1 << 15, "green:" LED_FUNCTION_STATUS "-1" },
> >> + {1 << 7, "yellow:" LED_FUNCTION_STATUS "-1" },
> >> + {1 << 14, "red:" LED_FUNCTION_STATUS "-2" },
> >> + {1 << 6, "yellow:" LED_FUNCTION_STATUS "-2" },
> >> + {1 << 13, "red:" LED_FUNCTION_STATUS "-3" },
> >> + {1 << 5, "yellow:" LED_FUNCTION_STATUS "-3" },
> >> + { }
> >> +};
But I'd still like better naming than red:status-2.
Pavel
--
http://www.livejournal.com/~pavelmachek
Attachment:
signature.asc
Description: PGP signature
