Re: [PATCH 2/2] leds: bcm63xxx: add support for BCM63xxx controller

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 22.11.2021 23:04, Florian Fainelli wrote:
On 11/15/21 1:11 AM, Rafał Miłecki wrote:
From: Rafał Miłecki <rafal@xxxxxxxxxx>

It's a new controller used on BCM4908, some BCM68xx and some BCM63xxx
SoCs.

Signed-off-by: Rafał Miłecki <rafal@xxxxxxxxxx>

Same comment as the binding, please s/bcm63xxx/bcm63xx/ for matchign
existing drivers/patterns.

[snip]

+
+#define BCM63XXX_MAX_LEDS			32> +
+#define BCM63XXX_GLB_CTRL			0x00
+#define BCM63XXX_MASK				0x04

This define appears unused.

Just like few other registers. I think it's still worth to define all hw
registers.



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux