On Tue, Sep 14, 2021 at 12:41:31AM +0200, Linus Walleij wrote: > On Mon, Sep 13, 2021 at 9:28 PM Rob Herring <robh@xxxxxxxxxx> wrote: > > > Convert the register-bit-led binding to DT schema format. > > > > As the example just repeats nearly identical nodes, trim it down to a > > few nodes and use some documented values for 'linux,default-trigger'. > > > > Cc: Linus Walleij <linus.walleij@xxxxxxxxxx> > > Cc: Pavel Machek <pavel@xxxxxx> > > Cc: linux-leds@xxxxxxxxxxxxxxx > > Signed-off-by: Rob Herring <robh@xxxxxxxxxx> > > Thanks for doing this! > > > v2: > > - Drop undocumented linux,default-trigger values > > Will this lead to warnings? People tend to want to use these. Yes. The list for linux,default-trigger was purposely limited rather than just throw in all the occurrences we could find. It's kind of a mess with similar or overlapping names. There's other and better ways to do this now. There's the 'function' property and you can link to another device. > > (Possibly we could actually create operating-system independent > triggers that make sense on any system. But it's another can > of worms we don't need to open today.) > > > + enum: > > + [ 0x1, 0x2, 0x4, 0x8, 0x10, 0x20, 0x40, 0x80, 0x100, 0x200, 0x400, 0x800, > > + 0x1000, 0x2000, 0x4000, 0x8000, 0x10000, 0x20000, 0x40000, 0x80000, > > + 0x100000, 0x200000, 0x400000, 0x800000, 0x1000000, 0x2000000, 0x4000000, > > + 0x8000000, 0x10000000, 0x20000000, 0x40000000, 0x80000000 ] > > That's an interesting looking enum :D > > But I can't think of anything better, so: We could define our own type, but I can't say I recall the need for this elsewhere. > Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx> Thanks. Rob
