Re: [PATCH 01/18] docs: Add block device (blkdev) LED trigger documentation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi!

> Add Documentation/ABI/testing/sysfs-class-led-trigger-blkdev to
> document:
> 
>   * /sys/class/leds/<led>/blink_time
>   * /sys/class/leds/<led>/interval
>   * /sys/class/leds/<led>/mode
>   * /sys/class/leds/<led>/add_blkdev
>   * /sys/class/leds/<led>/delete_blkdev
>   * /sys/class/leds/<led>/block_devices
> 
> Add /sys/block/<disk>/blkdev_leds to Documentation/ABI/testing/sysfs-block
> 
> Add overview in Documentation/leds/ledtrig-blkdev.rst

> +What:		/sys/class/leds/<led>/add_blkdev
> +Date:		September 2021
> +Contact:	Ian Pilcher <arequipeno@xxxxxxxxx>
> +Description:
> +		Associate a block device with this LED by writing its kernel
> +		name (as shown in /sys/block) to this attribute.  Multiple
> +		device names may be written at once, separated by whitespace.

This is seriously strange interface.

> +What:		/sys/class/leds/<led>/delete_blkdev
> +Date:		September 2021
> +Contact:	Ian Pilcher <arequipeno@xxxxxxxxx>
> +Description:
> +		Remove the association between this LED and a block device by
> +		writing the device's kernel name to this attribute.  Multiple
> +		device names may be written at once, separated by whitespace.
> +
> +What:		/sys/class/leds/<led>/block_devices
> +Date:		September 2021
> +Contact:	Ian Pilcher <arequipeno@xxxxxxxxx>
> +Description:
> +		Directory containing links to all block devices that are
> +		associated with this LED.

If you have directory with symlinks, why not use symlink() syscall
instead of add_blkdev, and unlink() syscall instead of delete_blkdev?

Best regards,
								Pavel
-- 
http://www.livejournal.com/~pavelmachek

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux