On Wed, 11 Aug 2021 11:57:59 +0200 Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > Instantiate a single LED based on the "led" subnode in DT. > This allows the user to control display brightness and blinking (backed > by hardware support) through the LED class API and triggers, and exposes > the display color. The LED will be named > "auxdisplay:<color>:<function>". > > When running in dot-matrix mode and if no "led" subnode is found, the > driver falls back to the traditional backlight mode, to preserve > backwards compatibility. > > Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> Reviewed-by: Marek Behún <kabel@xxxxxxxxxx> BTW, this driver does not need to depend on OF, methinks. The few instances of properties reading can be easily rewritten to device_* functions (from include/linux/property.h). The of_get_child_by_name() can become device_get_named_child_node(). Geert, what do you think? Marek