On Mon, Aug 09, 2021 at 06:50:44PM -0500, Ian Pilcher wrote: > On 8/9/21 5:43 PM, Marek Behún wrote: > > I confess that I am not very familiar with internal blkdev API. > > It's mainly a matter of symbol visibility. See this thread from a few > months ago: > > https://www.spinics.net/lists/linux-leds/msg18244.html > > Now ... my code currently lives in block/, so there isn't actually > anything technically preventing it from iterating through the block > devices. > > The reactions to Enzo's patch (which you can see in that thread) make me > think that anything that iterates through all block devices is likely to > be rejected, but maybe I'm reading too much into it. > > > Greg / Christoph - > > (As you were the people who expressed disapproval of Enzo's patch to > export block_class and disk_type ...) > > Can you weigh in on the acceptability of iterating through the block > devices (searching by name) from LED trigger code within the block > subsystem (i.e. no new symbols would need to be exported)? > > This would allow the trigger to implement the sysfs API that Marek and > Pavel want. No idea, let's see the change first, we can never promise anything :) thanks, greg k-h
