Re: [PATCH 1/1] leds: blinkm: remove unused variable 'ret' in blinkm_init_hw()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed 2021-05-19 20:41:36, Zhen Lei wrote:
> GCC reports the following warning with W=1:
> 
> drivers/leds/leds-blinkm.c:483:6: warning:
>  variable 'ret' set but not used [-Wunused-but-set-variable]
>   483 |  int ret;
>       |      ^~~
> 
> This variable is not used, remove it to fix the warning.
> 
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: Zhen Lei <thunder.leizhen@xxxxxxxxxx>

Sounds like valid warning, and likely function should just propagate
the error value.

It would be good if someone with the hardware could take a look.

Best regards,
								Pavel
								
-- 
http://www.livejournal.com/~pavelmachek

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux