Hi please use "reply-all" in the future when replying so that all participants receive the email. 2021. június 16., szerda 1:40 keltezéssel, leo60228 írta: > Thanks for the feedback, I'll start working on a V2. I have a few > questions, though. > > > There are multicolor leds (see Documentation/leds/leds-class-multicolor), maybe that would be a better fit instead of creating 4x3 LED devices? > > I could definitely be incorrect here, but my understanding is that > multicolor LEDs were an abstraction automatically created from > separate red, green, and blue LEDs. I'm not entirely sure what you mean. I'm not aware that LED multicolor class devices would be instantiated from 3 ordinary LED devices - although it's possible I have missed it. > > > This is not an appropriate LED class device name. Please see Documentation/leds/leds-class for details. > > I was worried I misunderstood something, but I thought this was > correct. "white:status" is given as an example of a correct name, and > this paragraph from the leds-class docs made me think that appending > -N was the correct format for multiple LEDs with the same function: > Ahh, you're right. My bad. The "devicename" part is indeed optional. > > It is possible that more than one LED with the same color and function will be required for given platform, differing only with an ordinal number. In this case it is preferable to just concatenate the predefined LED_FUNCTION_* name with required “-N” suffix in the driver. fwnode based drivers can use function-enumerator property for that and then the concatenation will be handled automatically by the LED core upon LED class device registration. Regards, Barnabás Pőcze
