Return -EBUSY if the data is already in use (instead of returning success). Fixes: 9d7cffaf99f5 ("leds: Add driver for the ISSI IS31FL32xx family of LED controllers") Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> --- Not tested. It prints an error so the intention seems clear, but sometimes making stuff a failure instead of a success can lead to unexpected problems in production. On the other hand, if this is not an error then shouldn't we do a continue instead of a goto err? drivers/leds/leds-is31fl32xx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/leds/leds-is31fl32xx.c b/drivers/leds/leds-is31fl32xx.c index 3b55af9a8c58..e6f34464914f 100644 --- a/drivers/leds/leds-is31fl32xx.c +++ b/drivers/leds/leds-is31fl32xx.c @@ -386,6 +386,7 @@ static int is31fl32xx_parse_dt(struct device *dev, dev_err(dev, "Node %pOF 'reg' conflicts with another LED\n", child); + ret = -EBUSY; goto err; } -- 2.30.2