On Tue, 1 Jun 2021 19:09:03 +0800 Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx> wrote: > The error code is missing in this code scenario, add the error code > '-EINVAL' to the return value 'ret'. > > Eliminate the follow smatch warning: > > drivers/leds/leds-is31fl32xx.c:388 is31fl32xx_parse_dt() warn: missing > error code 'ret'. > > Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx> > Signed-off-by: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx> Good catch! Acked-by: David Rivshin <drivshin@xxxxxxxxxxx> You might also want to add a: Fixes: 9d7cffaf99f5 ("leds: Add driver for the ISSI IS31FL32xx family of LED controllers") > --- > drivers/leds/leds-is31fl32xx.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/leds/leds-is31fl32xx.c b/drivers/leds/leds-is31fl32xx.c > index 2180255..899ed94 100644 > --- a/drivers/leds/leds-is31fl32xx.c > +++ b/drivers/leds/leds-is31fl32xx.c > @@ -385,6 +385,7 @@ static int is31fl32xx_parse_dt(struct device *dev, > dev_err(dev, > "Node %pOF 'reg' conflicts with another LED\n", > child); > + ret = -EINVAL; > goto err; > } >