On Tue, 1 Jun 2021 23:12:57 +0200 Andrew Lunn <andrew@xxxxxxx> wrote: > On Tue, Jun 01, 2021 at 02:51:51AM +0200, Marek Behún wrote: > > Move setting of the LED_UNREGISTERING before deactivating the > > trigger in led_classdev_unregister(). > > > > It can be useful for a LED trigger to know whether it is being > > deactivated due to the LED being unregistered. This makes it > > possible for LED drivers which implement trigger offloading to > > leave the LED in HW triggering mode when the LED is unregistered, > > instead of disabling it. > > Humm, i'm not sure that is a good idea. I don't expect my Ethernet > switch to keep forwarding frames when i unload the driver. We want to make it so that when leds-turris-omnia driver is unloaded, the LEDs will start blinking in HW mode as they did before the driver was loaded. This is needed for that. Marek
