On Fri, 28 May 2021, Pavel Machek wrote: > Hi! > > > > drivers/leds/leds-as3645a.c:198: warning: expecting prototype for as3645a_set_config(). Prototype was for as3645a_set_current() instead > > > > > > Cc: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> > > > Cc: Pavel Machek <pavel@xxxxxx> > > > Cc: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > > > Cc: linux-leds@xxxxxxxxxxxxxxx > > > Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx> > > > --- > > > drivers/leds/leds-as3645a.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/leds/leds-as3645a.c b/drivers/leds/leds-as3645a.c > > > index e8922fa033796..c41937ff8fd33 100644 > > > --- a/drivers/leds/leds-as3645a.c > > > +++ b/drivers/leds/leds-as3645a.c > > > @@ -185,7 +185,7 @@ static int as3645a_read(struct as3645a *flash, u8 addr) > > > */ > > > > > > /** > > > - * as3645a_set_config - Set flash configuration registers > > > + * as3645a_set_current - Set flash configuration registers > > > * @flash: The flash > > > * > > > * Configure the hardware with flash, assist and indicator currents, as well as > > > > Thanks for the patch. > > > > The entire comment could be removed. It's wrong and doesn't really tell > > more than what you can read in the two functions below (the two are result > > of splitting one the documentation was written for). > > I just took the patch, I'll happily take a follow up. I'll follow-up. No problem. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
