On Wed, May 26, 2021 at 08:00:19PM +0200, Marek Behún wrote:
> Add support for HW offloading of the netdev trigger.
>
> We need to export the netdev_led_trigger variable so that drivers may
> check whether the LED is set to this trigger.
Without seeing the driver side, it is not obvious to me why this is
needed. Please add the driver changes to this patchset, so we can
fully see how the API works.
> -static struct led_trigger netdev_led_trigger = {
> +struct led_trigger netdev_led_trigger = {
> .name = "netdev",
> .activate = netdev_trig_activate,
> .deactivate = netdev_trig_deactivate,
> .groups = netdev_trig_groups,
> };
> +EXPORT_SYMBOL_GPL(netdev_led_trigger);
If these are going to be exported, maybe they should be made const to
protect them a bit?
Andrew
