Hello, On Wed, Feb 17, 2021 at 12:02:47PM +0100, Enrico Weigelt, metux IT consult wrote: > On 16.02.21 14:30, Andreas Eberlein wrote: > > The DMI_PRODUCT_NAME entry on current firmware of PC Engines APU1 changed > > from "APU" to "apu1" > > > > This modification adds the missing DMI data and thereby the LED support for > > the PC Engines APU1 with firmware versions >= 4.6.8. > > Do you have a device for more intensive testing ? I have an apu1d4 on my desk, which is supposed to be used soon, but available for testing at the moment. I put the latest coreboot bios version 4.13.0.3 on it yesterday. > In that case I'd like to suggest splitting the driver into gpio and > gpio-based LED (using leds-gpio) - just like already I did for apu2/3/4. > Maybe this even could also be moveed into the apu2 driver. This probably > just makes sense if there're more gpio-connected devices than just LED) > > Personally, I don't have access to the old apu1 board (IIRC not even > produced anymore for several years), so I didn't dare to touch anything > here. If you give me a hint, which tree or patchset should be tested, and some hints what should be tested, I can try. > Note that apu1 vs. apu2/3/4 have completely different SOC with different > gpio logic - that was one of the reasons for writing a completely new > driver for apu2+ from scrath, rather than extending the old one. Thanks for that work. I have to admit someone from the fli4l linux router distribution team also wrote LED and button drivers for the APU boards, but never managed to upstream those. :-/ If someone is interested, those are spread in our Subversion repository, but the apu drivers are here: https://repo.nettworks.org/svn/fli4l/branches/4.0/trunk/src/packages/src/src/fli4l/hwsupp/pcengines-apu/ Personally, I'd rather have mainline drivers for all that boards. Don't know if it still makes sense for the older wrap or alix boards, though. I also have those lying around. ;-) Greets Alex -- /"\ ASCII RIBBON | »With the first link, the chain is forged. The first \ / CAMPAIGN | speech censured, the first thought forbidden, the X AGAINST | first freedom denied, chains us all irrevocably.« / \ HTML MAIL | (Jean-Luc Picard, quoting Judge Aaron Satie)
Attachment:
signature.asc
Description: PGP signature
