Hi! > > > +static struct simatic_ipc_led simatic_ipc_leds_io[] = { > > > + {1 << 15, "simatic-ipc:green:run-stop"}, > > > + {1 << 7, "simatic-ipc:yellow:run-stop"}, > > > + {1 << 14, "simatic-ipc:red:error"}, > > > + {1 << 6, "simatic-ipc:yellow:error"}, > > > + {1 << 13, "simatic-ipc:red:maint"}, > > > + {1 << 5, "simatic-ipc:yellow:maint"}, > > > + {0, ""}, > > > +}; > > > > Please use names consistent with other systems, this is user > > visible. If you have two-color power led, it should be > > :green:power... See include/dt-bindings/leds/common.h . > > Well we wanted to pick names that are printed on the devices and would > like to stick to those. Has been a discussion ... > Can we have symlinks to have multiple names per LED? No symlinks. We plan to have command line tool to manipulate LEDs, aliases might be possible there. > How strong would you feel about us using our names? Strongly. :-) Do you have a picture how the leds look like? Best regards, Pavel -- http://www.livejournal.com/~pavelmachek
Attachment:
signature.asc
Description: Digital signature