> El 23 feb 2021, a las 9:58, Pavel Machek <pavel@xxxxxx> escribió: > > Hi! > >>>> This is proven to work in BMIPS BE/LE and ARM BE/LE, as used in bcm2835-rng >>>> and bcmgenet drivers. >>>> Both should also be inline functions. >>> >>> >>> >>>> -#ifdef CONFIG_CPU_BIG_ENDIAN >>>> - iowrite32be(data, reg); >>>> -#else >>>> - writel(data, reg); >>>> -#endif >>>> + /* MIPS chips strapped for BE will automagically configure the >>>> + * peripheral registers for CPU-native byte order. >>>> + */ >>> >>> Bad comment style. >> >> I just wanted to copy the same comment as the one in bcm2835-rng and bcmgenet… >> https://github.com/torvalds/linux/blob/3b9cdafb5358eb9f3790de2f728f765fef100731/drivers/char/hw_random/bcm2835-rng.c#L42-L60 >> https://github.com/torvalds/linux/blob/3b9cdafb5358eb9f3790de2f728f765fef100731/drivers/net/ethernet/broadcom/genet/bcmgenet.c#L71-L88 >> > > Yeah, but ideally you should not be copying comments; there should be > one central place which does it and does it right. I’m open to suggestions :). Which central place would be a good place for you? > > Pavel > > -- > http://www.livejournal.com/~pavelmachek
