On Sat, 20 Feb 2021 17:34:12 +0100 Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > Hi, > > On 2/20/21 4:16 PM, Marek Behun wrote: > > On Sat, 20 Feb 2021 13:24:36 +0100 > > Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > > > >> + data->led_mute.max_brightness = LED_ON; > > > > These constants are obsolete since we now support variable maximum > > brightness. Just put 1 there. > > Ok, any other remarks wrt the LED bits before I send out a v3 ? I will review the remaining patches tonight.