Hi!
> From: Gene Chen <gene_chen@xxxxxxxxxxx>
>
> Add MT6360 LED driver include 2-channel Flash LED with torch/strobe mode,
> 3-channel RGB LED support Register/Flash/Breath Mode, and 1-channel for
> moonlight LED.
What kind of ninja mutant hardware is this?
Can we make this go to drivers/leds/flash?
> +static int mt6360_flash_brightness_set(struct led_classdev_flash *fl_cdev, u32 brightness)
> +{
> + /*
> + * Due to the current spike when turning on flash, let brightness to be kept by framework.
> + * This empty function is used to prevent led_classdev_flash register ops check failure.
> + */
Please stick to 80 columns.
> +static int mt6360_init_common_properties(struct mt6360_led *led, struct led_init_data *init_data)
> +{
> + const char * const states[] = { "off", "keep", "on" };
No need for space between * and const.
Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek
Attachment:
signature.asc
Description: PGP signature
