AW: [PATCH v2 4/4] leds: lp50xx: add setting of default intensity from DT

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Pavel,
> 
> > Signed-off-by: Sven Schuchmann <schuchmann@xxxxxxxxxxxxxxxxx>
> 
> Check your email headers, empty To: is strange.
> 
> > diff --git a/drivers/leds/leds-lp50xx.c b/drivers/leds/leds-lp50xx.c
> > index 79bc071c31fb..e8aa36c7e963 100644
> > --- a/drivers/leds/leds-lp50xx.c
> > +++ b/drivers/leds/leds-lp50xx.c
> > @@ -504,6 +504,24 @@ static int lp50xx_probe_dt(struct lp50xx *priv)
> >  			num_colors++;
> >  		}
> >
> > +		if (fwnode_property_count_u32(child, "default-intensity")
> > +			== num_colors) {
> > +
> > +			int j, def_int[LP50XX_LEDS_PER_MODULE];
> 
> No need for empty line?

Using "git send-email", maybe I am doing something wrong here, will check.


> > +			ret = fwnode_property_read_u32_array(child,
> > +				"default-intensity", def_int, num_colors);
> > +			if (ret) {
> > +				dev_err(&priv->client->dev,
> > +					"Cannot read default-intensity: %d\n",
> > +					ret);
> > +				goto child_out;
> > +			}
> 
> Just ignore such error?

Yes, I will ignore in the next version

Best Regards,

   Sven




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux