On Wed, Jan 13, 2021 at 06:30:18PM +0100, Uwe Kleine-König wrote: > Usage is as follows: > > myled=ledname > tty=ttyS0 > > echo tty > /sys/class/leds/$myled/trigger > echo $tty > /sys/class/leds/$myled/ttyname > > . When this new trigger is active it periodically checks the tty's > statistics and when it changed since the last check the led is flashed > once. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> > --- > Hello, > > On Wed, Jan 13, 2021 at 05:16:00PM +0100, Greg Kroah-Hartman wrote: > > This causes the following build warning with the patch applied: > > > > drivers/leds/trigger/ledtrig-tty.c:19:13: warning: ‘ledtrig_tty_halt’ defined but not used [-Wunused-function] > > 19 | static void ledtrig_tty_halt(struct ledtrig_tty_data *trigger_data) > > | ^~~~~~~~~~~~~~~~ > > > > Can you fix this up and just resend this patch (the other 2 are already > > in my tree), > > oh indeed. Thanks for catching this and so preventing me still more > shame when I have to receive a dozen or so patches that fix this :-) > Droping this function is the only change since v10. > > > so that I can queue it up? > > Oh, so you are LED maintainer now? My congratulations. > (Honestly, do you plan to apply this without their ack? Not that I'm > against you doing that, I'm happy if I can archive this patch series as > done, but I'm a bit surprised.) It's drug on for so long now, the infrastructure that this driver needs has now bee merged, so I see no reason why this driver can't be taken now. I offered up a "any objections?" in the past, and have gotten none, so I will take that for quiet acceptance :) thanks, greg k-h
