Hi Pavel,
will send a new version with some minor tweaks!
On Wed, Dec 30, 2020 at 8:09 PM Pavel Machek <pavel@xxxxxx> wrote:
> > + if (ret1 || ret2) {
> > + dev_err(rt->dev,
> > + "either %s or %s missing from DT, using HW max\n",
> > + resistance, max_ua_prop);
> > + max_ma = RT8515_MAX_IOUT_MA;
> > + max_intensity = hw_max;
> > + goto out_assign_max;
> > + }
>
> I'd go with some minimum values if we don't have complete information
> from devicetree.
I think this is safe because of the way the current limiting
resistors work, the device is designed to have hardware
constraints on currents. The max brightness is the max
current as limited by hardware. It is not possible to break
this LED with software.
Of course someone could have mounted the LED in violation
of the manual but ... we can't protect for everything I think.
The resistances etc is mainly here to give v4l an idea of the
current since V4L is a current-oriented API. Not a good fit
in this case, but with these DT properties we can make it fit
somewhat so ... ¯\_(ツ)_/¯
> > +MODULE_LICENSE("GPL v2");
>
> v2+, iirc?
It seems GPL-2.0-or-late just use "GPL" as license so I changed
to that.
Yours,
Linus Walleij
