On Fri, 11 Dec 2020 03:48:40 +0200 Abanoub Sameh <abanoubsameh8@xxxxxxxxx> wrote: > This gets rid of enum led_brightness in the main led files, > because it is deprecated, and an int can be used instead, > or maybe even a uint8_t since it only goes up to 255. > Next we can also patch the other files to get rid of it completely. 1. unsigned int should be used IMO - using int may force all implementers to check for negative value and return -EINVAL, which is stupid - some LED controllers may offer more than 8bit brightness value, so no uint8_t 2. I think we should remove all usages with one commit Marek