Re: [PATCH 2/2 v5] leds: rt8515: Add Richtek RT8515 LED driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Linus,

Thanks for the update.

On Fri, Nov 13, 2020 at 01:42:39PM +0100, Linus Walleij wrote:
...
> +static int rt8515_led_flash_strobe_set(struct led_classdev_flash *fled,
> +				       bool state)
> +{
> +	struct rt8515 *rt = to_rt8515(fled);
> +	struct led_flash_setting *timeout = &fled->timeout;
> +	int brightness = 4; /* max 16 */

Just a question on the unit --- did the other spec shed any light on what
the relation between this setting and the current might be?

But if it's not known, or even estimated, then I guess you could use these
values.

4 seems like a random number though. I'd use maximum as the default.

-- 
Sakari Ailus



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux