On Wed, Nov 11, 2020 at 12:05 PM Sakari Ailus <sakari.ailus@xxxxxx> wrote: > On Wed, Nov 11, 2020 at 02:14:16AM +0100, Linus Walleij wrote: > > Add a YAML devicetree binding for the Richtek RT8515 > > dual channel flash/torch LED driver. > > + led: > > + type: object > > + $ref: common.yaml# > > + properties: > > + function: true > > + color: true > > + flash-max-timeout-us: true > > Don't you also need flash-max-microamp and led-max-microamp? As the maximum > current for the LED may well be less than the driver can provide. I wish I could add that. The problem is that we don't know anything about the microamps for this Richtek component. There is no public datasheet available. I have asked Richtek, they answered as follows: "RT8515 had EOL already. So, we couldn't provide the datasheet. Thank you." I do not quite understand their answer but they at least answered. I have a few out-of-tree drivers, from Asus Zenfone, and from the numerous Samsung mobiles using this. None of the outoftree code makes any reference to the actual microamperes. They make a setting from 1..100 "units" and that is handled by some kind of userspace that I do not have the code for. If someone knows of a source code for this userspace I would be happy to take a look so we can at least figure out if it is linear. Yours, Linus Walleij