Hi!
> This adds a driver for the Richtek RT8515 dual channel
> torch/flash white LED driver.
>
> This LED driver is found in some mobile phones from
> Samsung such as the GT-S7710 and GT-I8190.
Cc: phone-devel@vger.
> drivers/leds/Kconfig | 11 ++
> drivers/leds/Makefile | 1 +
> drivers/leds/leds-rt8515.c | 303 +++++++++++++++++++++++++++++++++++++
Let's put this into drivers/leds/flash. You may need to create it.
> +// SPDX-License-Identifier: GPL-2.0-only
GPL-2+ would be nicer if you can.
> +struct rt8515 {
> + struct led_classdev_flash fled;
> + struct v4l2_flash *v4l2_flash;
> + struct mutex lock;
> + struct regulator *reg;
> + struct gpio_desc *ent;
> + struct gpio_desc *enf;
-> enable_torch or at least en_torch / en_flash?
Otherwise it looks good.
Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek
Attachment:
signature.asc
Description: Digital signature
