On Fri, Oct 30, 2020 at 08:08:01AM -0500, Dan Murphy wrote:
> Marek
>
> On 10/29/20 9:39 PM, Marek Behún wrote:
> > Commit 77dce3a22e89 ("leds: disallow /sys/class/leds/*:multi:* for now")
> > disallows LED_COLOR_ID_MULTI for now, and instead LED_COLOR_ID_RGB
> > should be used. Fix this is leds-class-multicolor binding.
> >
> > After we have some usecases for non-RGB multicolor LEDs, this can be
> > changed.
> >
> > Signed-off-by: Marek Behún <kabel@xxxxxxxxxx>
> > Fixes: 77dce3a22e89 ("leds: disallow /sys/class/leds/*:multi:* for now")
> > Cc: devicetree@xxxxxxxxxxxxxxx
> > Cc: robh+dt@xxxxxxxxxx
> > ---
> > .../devicetree/bindings/leds/cznic,turris-omnia-leds.yaml | 4 ++--
> > .../devicetree/bindings/leds/leds-class-multicolor.yaml | 4 ++--
> > 2 files changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml b/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml
> > index fe7fa25877fd..2015db9b7618 100644
> > --- a/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml
> > +++ b/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml
> > @@ -73,14 +73,14 @@ examples:
> > * LEDs.
> > */
> > reg = <0>;
> > - color = <LED_COLOR_ID_MULTI>;
> > + color = <LED_COLOR_ID_RGB>;
> > function = LED_FUNCTION_POWER;
> > linux,default-trigger = "heartbeat";
> > };
> > multi-led@a {
> > reg = <0xa>;
> > - color = <LED_COLOR_ID_MULTI>;
> > + color = <LED_COLOR_ID_RGB>;
> > function = LED_FUNCTION_INDICATOR;
> > function-enumerator = <1>;
> > };
> > diff --git a/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml b/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml
> > index b1a53f054b89..9faa3609a6bb 100644
> > --- a/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml
> > +++ b/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml
>
> Why are you resubmitting the multicolor.yaml?
>
> https://lore.kernel.org/patchwork/patch/1320863/
>
> This is waiting on DT review.
I'm expecting another version as you commented on it.
Rob
