Pavel, various device classes in kernel embed struct device by value, instead of as a pointer (for example struct mdio_device or struct net_device). Would you be interested in this for struct led_classdev, or do you prefer struct led_classdev to have the underlying struct device as a pointer? The benefit would be that dev->priv would be free to use by the LED driver directly. Currently this pointer points to the struct led_classdev. Marek