Hi! > > > +{ > > > + struct mt6360_led *led = container_of(lcdev, struct mt6360_led, flash.led_cdev); > > > + struct mt6360_priv *priv = led->priv; > > > + u32 enable_mask = MT6360_TORCHEN_MASK | MT6360_FLCSEN_MASK(led->led_no); > > > + u32 val = (level) ? MT6360_FLCSEN_MASK(led->led_no) : 0; > > > + u32 prev = priv->fled_torch_used, curr; > > > + int ret; > > > + > > > + dev_dbg(lcdev->dev, "[%d] brightness %d\n", led->led_no, level); > > > + if (priv->fled_strobe_used) { > > > + dev_warn(lcdev->dev, "Please disable strobe first [%d]\n", priv->fled_strobe_used); > > > + return -EINVAL; > > > + } > > > > So... how does its userland interface look like? > > > > 1. set FLED1 brightness > # echo 1 > /sys/class/leds/white:flash1/flash_brightness > 2. enable FLED1 strobe > # echo 1 > /sys/class/leds/white:flash1/flash_strobe > 3 . turn off FLED1 strobe (just used to gaurantee the strobe mode > flash leds must be turned off) > # echo 0 > /sys/class/leds/white:flash1/flash_strobe I believe I'd preffer only exposing torch functionality in /sys/class/leds. .. strobe can be supported using v4l2 APIs. Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Attachment:
signature.asc
Description: PGP signature