Hi!
> names are not suited for this, since in some situations a PHY device
> name can look like this
> d0032004.mdio-mii:01
> or even like this
> /soc/internal-regs@d0000000/mdio@32004/switch0@10/mdio:08
> Clearly this cannot be used as the `device` part of a LED name.
>
> Signed-off-by: Marek Behún <marek.behun@xxxxxx>
> ---
> drivers/net/phy/phy_device.c | 3 +++
> include/linux/phy.h | 3 +++
> 2 files changed, 6 insertions(+)
>
> diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
> index 8adfbad0a1e8f..38f56d39f1229 100644
> --- a/drivers/net/phy/phy_device.c
> +++ b/drivers/net/phy/phy_device.c
> @@ -9,6 +9,7 @@
>
> #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
>
> +#include <linux/atomic.h>
> #include <linux/bitmap.h>
> #include <linux/delay.h>
> #include <linux/errno.h>
> @@ -892,6 +893,7 @@ EXPORT_SYMBOL(get_phy_device);
> */
> int phy_device_register(struct phy_device *phydev)
> {
> + static atomic_t phyindex;
> int err;
>
> err = mdiobus_register_device(&phydev->mdio);
I'd put the static out of the function... for greater visibility.
Otherwise: Reviewed-by: Pavel Machek <pavel@xxxxxx>
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Attachment:
signature.asc
Description: PGP signature
