Hi! > this is v4 of my RFC adding support for LEDs connected to Marvell PHYs. > > Please note that if you want to test this, you still need to first apply > the patch adding the LED private triggers support from Pavel's tree. > https://git.kernel.org/pub/scm/linux/kernel/git/pavel/linux-leds.git/commit/?h=for-next&id=93690cdf3060c61dfce813121d0bfc055e7fa30d > > What I still don't like about this is that the LEDs created by the code > don't properly support device names. LEDs should have name in format > "device:color:function", for example "eth0:green:activity". > > The code currently looks for attached netdev for a given PHY, but > at the time this happens there is no netdev attached, so the LEDs gets > names without the device part (ie ":green:activity"). > > This can be addressed in next version by renaming the LED when a netdev > is attached to the PHY, but first a API for LED device renaming needs to > be proposed. I am going to try to do that. This would also solve the > same problem when userspace renames an interface. > > And no, I don't want phydev name there. Ummm. Can we get little more explanation on that? I fear that LED device renaming will be tricky and phydev would work around that nicely. Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Attachment:
signature.asc
Description: PGP signature
