Re: [PATCH v6 2/3] leds: initial support for Turris Omnia LEDs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 22 Jul 2020 09:15:42 +0200
Pavel Machek <pavel@xxxxxx> wrote:

> Hi!
> 
> > +
> > +/*
> > + * On the front panel of the Turris Omnia router there is also a button which can be used to control
> > + * the intensity of all the LEDs at once, so that if they are too bright, user can dim them.
> > + * The microcontroller cycles between 8 levels of this global brightness (from 100% to 0%), but this
> > + * setting can have any integer value between 0 and 100. It is therefore convenient to be able to
> > + * change this setting from software.
> > + * We expose this setting via a sysfs attribute file called "brightness". This file lives in the
> > + * device directory of the LED controller, not an individual LED, so it should not confuse users.
> > + */  
> 
> Lets keep comments formatted to 80 columns. This overflew my screen
> and is unreadable.
> 							Pavel

OK. But you are aware that default limit was increased to 100 columns,
right?

Marek



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux