On Sat, Jul 18, 2020 at 4:25 AM Jacek Anaszewski <jacek.anaszewski@xxxxxxxxx> wrote: > > > >> The reason for not having a function at the moment is that I took a > >> look at include/dt-bindings/leds/common.h and could not find any > >> function that could reasonably apply. This basically controls a RGB > >> connector on the motherboard which serves no particular function - you > >> can plug a RGB fan or anything else you want and control it in any > >> fashion. Is there a function that applies to this use-case? > > According to common LED bindings you should propose a new function > if none of the existing ones fits your needs. > > > This is normally used for motherboard lightning, right? I believe this > > is getting common on gaming boards, and we want common support for > > that. > > I agree. These boards are indeed far from being a rarity so having a function for them (maybe named LED_FUNCTION_RGB_HEADER?) makes sense IMHO. I'll submit a patch for that with the next revision. Speaking of which, after looking at the multicolor patchset it is pretty obvious that it would be a much better way to expose this RGB header, so I think I will wait until it is merged and adapt the driver to use it. Thanks for the feedback! Alex.
