Hi, this version addresses some of Dan's suggestions. Uses the multicolor framework. Marek changes since v4: - fixed a typo in dt-binding - change to dt-binding documentation as suggested by Dan Murphy so that it is less confusing - cleaning up some things in the code addressed by Dan Murphy - added sysfs ABI documentation for the brightness file controlling the brightness of the whole panel changes since v3: - added a note in yaml scheme to the description of multi-led property that no subnodes for the specific channels are needed since this controller only supports RGB LEDs. A comment into the device-tree example in the yaml scheme is added saying the same thing. changes since v2: - using multicolor LED framework now, major rewrite - added support for global brightness (Omnia has a button which can switch between 8 levels of intensity of all the LEDs at once, but in reality any value between 0% and 100% can be set, and we want to access this setting via software) Marek Behún (3): dt-bindings: leds: add cznic,turris-omnia-leds binding leds: initial support for Turris Omnia LEDs Documentation: ABI: leds-turris-omnia: document sysfs attribute .../sysfs-class-led-driver-turris-omnia | 14 + .../leds/cznic,turris-omnia-leds.yaml | 88 ++++++ drivers/leds/Kconfig | 11 + drivers/leds/Makefile | 1 + drivers/leds/leds-turris-omnia.c | 293 ++++++++++++++++++ 5 files changed, 407 insertions(+) create mode 100644 Documentation/ABI/testing/sysfs-class-led-driver-turris-omnia create mode 100644 Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml create mode 100644 drivers/leds/leds-turris-omnia.c -- 2.26.2