Re: [PATCH v7 5/5] backlight: add led-backlight driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 04 Oct 2019, Jean-Jacques Hiblot wrote:

> Hi Lee,
> 
> On 04/10/2019 16:39, Lee Jones wrote:
> > On Wed, 18 Sep 2019, Jean-Jacques Hiblot wrote:
> > 
> > > From: Tomi Valkeinen <tomi.valkeinen@xxxxxx>
> > > 
> > > This patch adds a led-backlight driver (led_bl), which is similar to
> > > pwm_bl except the driver uses a LED class driver to adjust the
> > > brightness in the HW. Multiple LEDs can be used for a single backlight.
> > > 
> > > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@xxxxxx>
> > > Signed-off-by: Jean-Jacques Hiblot <jjhiblot@xxxxxx>
> > > Acked-by: Pavel Machek <pavel@xxxxxx>
> > > Reviewed-by: Daniel Thompson <daniel.thompson@xxxxxxxxxx>
> > > ---
> > >   drivers/video/backlight/Kconfig  |   7 +
> > >   drivers/video/backlight/Makefile |   1 +
> > >   drivers/video/backlight/led_bl.c | 260 +++++++++++++++++++++++++++++++
> > >   3 files changed, 268 insertions(+)
> > >   create mode 100644 drivers/video/backlight/led_bl.c
> > Applied, thanks.
> 
> It will break the build because it relies on functions not yet in the LED
> core (devm_led_get() for v7 or devm_of_led_get() for v8)

You're right, un-applied, thanks.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux