Hi! > > Regarding this ASCII art - I presume you wanted to follow > > Documentation/devicetree/bindings/leds/leds-trigger-pattern.txt. > > > > It was added to bindings because we support 'pattern' value > > for linux,default-trigger, which in turn looks for 'led-pattern' > > property, whose format needs to be documented in the LED bindings. > > > > leds-trigger-pattern.txt documents only common syntax for software > > pattern engine. Currently we don't have a means to setup hw_pattern > > for the pattern trigger from DT, which is obvious omission and your > > patch just brings it to light. > > > > That said, I propose to fix it alongside and introduce led-hw-pattern > > property. When present, ledtrig-pattern would setup the pattern > > using pattern_set op, similarly as if it was set via sysfs hw_pattern > > file. > > > > Only in this case placing the pattern depiction here would be justified. > > Otherwise, it would have to land in the ABI documentation. > > You are okay, if I move it to Documentation/ABI/testing/sysfs-class-led-driver-el15203000 ? I don't see if this got a reply. Yes, Documentation/ABI/testing/sysfs-class-led-driver-el15203000 sounds like a right place for the sysfs description. Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Attachment:
signature.asc
Description: Digital signature
