Hi! > >>>diff --git a/Documentation/ABI/testing/sysfs-class-led > >>>b/Documentation/ABI/testing/sysfs-class-led > >>>index 5f67f7a..fdfed3f 100644 > >>>--- a/Documentation/ABI/testing/sysfs-class-led > >>>+++ b/Documentation/ABI/testing/sysfs-class-led > >>>@@ -61,3 +61,16 @@ Description: > >>> gpio and backlight triggers. In case of the backlight trigger, > >>> it is useful when driving a LED which is intended to indicate > >>> a device in a standby like state. > >>>+ > >>>+What: /sys/class/leds/<led>/current-trigger > >>>+Date: September 2019 > >>>+KernelVersion: 5.5 > >>>+Contact: linux-leds@xxxxxxxxxxxxxxx > >>>+Description: > >>>+ Set the trigger for this LED. A trigger is a kernel based source > >>>+ of LED events. > >>>+ Writing the trigger name to this file will change the current > >>>+ trigger. Trigger specific parameters can appear in > >>>+ /sys/class/leds/<led> once a given trigger is selected. For > >>>+ their documentation see sysfs-class-led-trigger-*. > >>>+ Reading this file will return the current LED trigger name. > >>Why do we need this new file can't we just update the current trigger > >>file implementation? > >We can't change existing ABI. It doesn't matter if it is documented > >or not - it's in place for very long time and you can't guarantee there > >are no users relying on triggers file show format. > > So if it has been in place for a very long time why do we need another ABI > that does sorta the same thing? > > This seems to be a bit confusing and extra. Agreed. Lets simply keep the existing ABI. Thanks, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Attachment:
signature.asc
Description: Digital signature
