On Tue 2019-09-17 19:19:55, Guido Günther wrote: > The driver currently reports successful initialization on every failure > as long as it's able to power off the regulator. Don't check the return > value of regulator_disable to avoid that. > > Signed-off-by: Guido Günther <agx@xxxxxxxxxxx> > --- > drivers/leds/leds-lm3692x.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/drivers/leds/leds-lm3692x.c b/drivers/leds/leds-lm3692x.c > index 487228c2bed2..f394669ad8f2 100644 > --- a/drivers/leds/leds-lm3692x.c > +++ b/drivers/leds/leds-lm3692x.c > @@ -312,15 +312,12 @@ static int lm3692x_init(struct lm3692x_led *led) > if (led->enable_gpio) > gpiod_direction_output(led->enable_gpio, 0); > > - if (led->regulator) { > - ret = regulator_disable(led->regulator); > - if (ret) > - dev_err(&led->client->dev, > - "Failed to disable regulator\n"); > - } > + if (led->regulator) > + regulator_disable(led->regulator); > > return ret; Overwriting return value is bad, but we should still print some kind of error message. Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Attachment:
signature.asc
Description: Digital signature