On Tue 2018-11-27 16:01:06, Linus Walleij wrote: > I ran into this when working on a keyboard driver for > the Razer family: the .blink_set() callback for setting > hardware blinking on a LED only exist in a non-blocking > (fastpath) variant, such as when blinking can be enabled > by simply writing a memory-mapped register and protected > by spinlocks. > > On USB keyboards with blinkable LEDs controlled with USB > out-of-band commands this will of course not work: these > calls need to come from process context. > > To support this: add a new .blink_set_blocking() callback > in the same vein as .brightness_set_blocking() and add > a flag and some code to the delayed work so that this > will be able to fire the .blink_set_blocking() call. > > ALl of this will be handled transparently from the > led_blink_set() call so all current users can keep > using that. > > Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx> Fun. I just realized thinkpad x60 needs something similar... -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Attachment:
signature.asc
Description: Digital signature
