Re: [PATCH 1/3] ACPI: Resolve objects on host-directed table loads

[Dan Murphy <dmurphy@xxxxxx>]

Pavel

On 5/31/19 7:23 AM, Pavel Machek wrote:
> Hi!
>
> > > diff --git a/drivers/acpi/acpica/tbxfload.c b/drivers/acpi/acpica/tbxfload.c
> > > index 4f30f06a6f78..61f2d46e52ba 100644
> > > --- a/drivers/acpi/acpica/tbxfload.c
> > > +++ b/drivers/acpi/acpica/tbxfload.c
> > > @@ -297,6 +297,17 @@ acpi_status acpi_load_table(struct acpi_table_header *table)
> > >   	status = acpi_tb_install_and_load_table(ACPI_PTR_TO_PHYSADDR(table),
> > >   						ACPI_TABLE_ORIGIN_EXTERNAL_VIRTUAL,
> > >   						FALSE, &table_index);
> > > +
> > > +	if (!ACPI_FAILURE(status)) {
> > Checkpatch should complain about putting brackets around single statement
> > if's.
> With multiline statement like that and including comment -- I'd say
> keep {'s. It is cleaner this way.

Maintainers preference.  I won't nack the patch for it.

Not sure their preference as I don't usually submit to acpi.

Dan


> 									Pavel