On 5/20/19 11:19 PM, Dan Murphy wrote:
Jacek
On 5/20/19 2:54 PM, Jacek Anaszewski wrote:
Hi Dan,
On 5/7/19 10:11 PM, Dan Murphy wrote:
Introduce the LM36274 LED driver. This driver uses the ti-lmu
MFD driver to probe this LED driver. The driver configures only the
LED registers and enables the outputs according to the config file.
The driver utilizes the TI LMU (Lighting Management Unit) LED common
framework to set the brightness bits.
Signed-off-by: Dan Murphy <dmurphy@xxxxxx>
---
drivers/leds/Kconfig | 7 ++
drivers/leds/Makefile | 1 +
drivers/leds/leds-lm36274.c | 174 ++++++++++++++++++++++++++++++++++++
3 files changed, 182 insertions(+)
create mode 100644 drivers/leds/leds-lm36274.c
diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
index 255fdd5e8491..db83a3feca01 100644
--- a/drivers/leds/Kconfig
+++ b/drivers/leds/Kconfig
@@ -791,6 +791,13 @@ config LEDS_LM3697
Say Y to enable the LM3697 LED driver for TI LMU devices.
This supports the LED device LM3697.
+config LEDS_LM36274
+ tristate "LED driver for LM36274"
+ depends on LEDS_TI_LMU_COMMON
Shouldn't we have "depends on MFD_TI_LMU" as well here?
Actually the LEDS_TI_LMU_COMMON flag should depend on MFD_TI_LMU.
Then it would inherit that dependency.
LEDS_TI_LMU_COMMON does not seem too have any dependency on MFD_TI_LMU,
and it would be incorrect to require enabling MFD_TI_LMU for all drivers
depending on TI_LMU_COMMON, that can be probed on their own, like
leds-lm3697.c .
--
Best regards,
Jacek Anaszewski
