On Mon, Apr 29, 2019 at 6:22 PM Pavel Machek <pavel@xxxxxx> wrote: > > > Make error returns more consistent... no behaviour change intended. > Pushed to my review and testing queue, thanks! P.S. I fixed prefix accordingly. > Signed-off-by: Pavel Machek <pavel@xxxxxx> > > diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c > index 726341f..7008a7f 100644 > --- a/drivers/platform/x86/thinkpad_acpi.c > +++ b/drivers/platform/x86/thinkpad_acpi.c > @@ -5808,7 +5808,7 @@ static int led_set_status(const unsigned int led, > return -EPERM; > if (!acpi_evalf(led_handle, NULL, NULL, "vdd", > (1 << led), led_sled_arg1[ledstatus])) > - rc = -EIO; > + return -EIO; > break; > case TPACPI_LED_OLD: > /* 600e/x, 770e, 770x, A21e, A2xm/p, T20-22, X20 */ > @@ -5832,10 +5832,10 @@ static int led_set_status(const unsigned int led, > return -EPERM; > if (!acpi_evalf(led_handle, NULL, NULL, "vdd", > led, led_led_arg1[ledstatus])) > - rc = -EIO; > + return -EIO; > break; > default: > - rc = -ENXIO; > + return -ENXIO; > } > > if (!rc) > > -- > (english) http://www.livejournal.com/~pavelmachek > (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- With Best Regards, Andy Shevchenko
