Re: [PATCH leds/for-next v3 1/1] leds: turris_omnia: add I2C and MACH_ARMADA_38X dependencies

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon 2019-04-29 20:32:26, Marek Behún wrote:
> This driver depends on I2C. There are linking problems otherwise, if for
> example CONFIG_LEDS_TURRIS_OMNIA=y and CONFIG_I2C=m.
> 
> Also add MACH_ARMADA_38X dependency, since it is unlikely that some
> other device will ever have a microcontroller with software compatible
> to that of Turris Omnia microcontroller.
> 
> Signed-off-by: Marek Behún <marek.behun@xxxxxx>
> Reported-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>

Acked-by: Pavel Machek <pavel@xxxxxx>

> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
> index d5b31a71a112..6b555d31c1be 100644
> --- a/drivers/leds/Kconfig
> +++ b/drivers/leds/Kconfig
> @@ -131,6 +131,8 @@ config LEDS_CR0014114
>  config LEDS_TURRIS_OMNIA
>  	tristate "LED support for CZ.NIC's Turris Omnia"
>  	depends on LEDS_CLASS
> +	depends on I2C
> +	depends on MACH_ARMADA_38X

You may want to do || COMPILE_TEST if you resubmit.
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux