On Thu 2019-04-04 11:55:27, Dmitry Torokhov wrote: > On Thu, Apr 4, 2019 at 11:41 AM Nick Crews <ncrews@xxxxxxxxxxxx> wrote: > > > > On Thu, Apr 4, 2019 at 11:43 AM Dmitry Torokhov <dtor@xxxxxxxxxx> wrote: > > > > > > On Thu, Apr 4, 2019 at 10:36 AM Guenter Roeck <groeck@xxxxxxxxxx> wrote: > > > > > > > > On Thu, Apr 4, 2019 at 10:11 AM Nick Crews <ncrews@xxxxxxxxxxxx> wrote: > > > > > > > > > > We want all backlights for the system keyboard to > > > > > use a common name, so the name "platform::kbd_backlight" > > > > > would be better than the current "chromeos::kbd_backlight" > > > > > name. Normally this wouldn't be worth changing, but the new > > > > > Wilco keyboard backlight driver uses the "platform" name. > > > > > We want to make it so all Chrome OS devices are consistent, > > > > > so we'll change the name here too. > > > > > > > > > > > > > Wondering - who is the "we" you are talking about ? > > > > You're right, I should have been more precise. > > I was referring to Pavel, Enric, and myself. Pavel had this opinion here: > > https://lkml.org/lkml/2019/4/4/1040. I don't know what Pavel meant by "we" > > in that comment, but I would guess that could mean the other LED maintainers > > as well? I talked with Enric 1:1 and he didn't see the problem with changing it, > > though perhaps he was only considering our use of the LED via powerd, > > and not users in general. I'm guessing Pavel's and Enric's meanings though, > > excuse me if I am misinterpreting. > > > > > > > > This also has a potential of breaking existing setups if somebody did > > > happen to match on entire name instead of suffix. Such changes have to > > > be considered very carefully; at this point I am against of doing > > > this. > > > > Would it make sense to keep the old name as is, and only make the new > > Wilco name begin with "platform:"? What would you think is best? > > Given that we do not have a single instance of platform::kbd_backlight > in kernel at this time I have no idea why Pavel is trying to push this > for Wilco driver. See the documentation in the email I sent few seconds ago. I hope it explains my reasoning, if not, I'll explain it. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Attachment:
signature.asc
Description: Digital signature
