Dan, > 1. Your patch order is incorrect. DT bindings first and then code. I shall correct this in the next series > 2. Is this driver for the end product or for a LED device driver? (I > cannot find a public reference for either) This driver communicates via I2C with the firmware running on the microcontroller on the Turris Omnia. I have the code for the microcontroller available, maybe somewhere in our documnetation is also a specification. But the specification for how it works is not that compilacated, I practically specified it in one of previous mails when I described all available LED commands. > 3. I do have a lot of comments on the code but without the data sheet > or understanding of what is being implemented they may not be worth while.