Re: [PATCH v2 leds-next 3/3] leds: turris-omnia: Add support for continuous brightness

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 3/28/19 10:56 PM, Marek Behun wrote:
I talked about this with Pavel, and decided that I will do RGB part
once multichannel/RGB LED class interface is decided. This would
just be a temporary workaround to support continuous brightness. If
you don't want it, I won't send it in next version.

I don't quite get what do you mean by "continuous" brightness in this
case. From what I see you just set the same brightness on all the
channels. Why is it called continuous?

I mean that the cardinality of the set of possible values for
brightness is 256 instead of 2. Maybe continuous is not the best name
for this.

Ah, OK, I overlooked that you're assigning brightness to the buf
elements. You can keep that if you like. No need for a separate patch.

--
Best regards,
Jacek Anaszewski



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux