Hi!
> This adds basic support for LEDs on the front side of CZ.NIC's Turris
> Omnia router.
>
> There are 12 RGB LEDs. The controller supports HW triggering mode for
> the LEDs, but this driver does not support it yet, and sets all the LEDs
> into SW mode upon probe.
>
> Also setting colors is not supported, only on/off state.
Thanks for doing this.
> @@ -0,0 +1,195 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * CZ.NIC's Turris Omnia LEDs driver
> + *
> + * 2019 by Marek Behun <marek.behun@xxxxxx>
> + */
Just make whole comment block //.
> +const char * const omnia_leds_names[OMNIA_BOARD_LEDS] = {
> + "omnia::userA",
> + "omnia::userB",
> + "omnia::pci3",
> + "omnia::pci2",
> + "omnia::pci1",
> + "omnia::wan",
> + "omnia::lan4",
> + "omnia::lan3",
> + "omnia::lan2",
> + "omnia::lan1",
> + "omnia::lan0",
> + "omnia::power",
> +};
Lets remove this; you should get names from device tree.
> + dev_info(dev, "Turris Omnia LEDs registered\n");
This may be a bit excessive, just remove it.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Attachment:
signature.asc
Description: Digital signature
