On Fri, Mar 22, 2019 at 9:49 AM Nick Crews <ncrews@xxxxxxxxxxxx> wrote: > > On Fri, Mar 22, 2019 at 5:35 AM Pavel Machek <pavel@xxxxxx> wrote: > > > > Hi! > > > > > The EC is in charge of controlling the keyboard backlight on > > > the Wilco platform. We expose a standard LED class device at > > > /sys/class/leds/wilco::kbd_backlight. This driver is modeled > > > after the standard Chrome OS keyboard backlight driver at > > > drivers/platform/chrome/cros_kbd_led_backlight.c > > > > Please make it platform::kbd_backlight . Userland should not need to > > know what wilco is... > > The corresponding device for normal chromeos devices is > "chromeos::kbd_backlight". I wanted to differentiate this device from > that one, so I thought that "wilco" a similar level of specific-ness as > "chromeos". Using "platform" seems too general. The power manager > daemon that controls the backlight just searches for LEDs ending with > "*:kbd_backlight" so it should work for that, and I figured any user just > browsing through sysfs would be able to guess what the LED does. > > This is maybe a question for those who will need to maintain the > Chrome OS system after adding this? Could some more > Chrome OS-specific people chime in on this? I also CC'ed Simon > Que, the author of the original driver (Simon, we are talking about > https://lkml.org/lkml/2019/3/21/999) >From talking to Simon, since the interface is the same, I'll just keep the name as "chromeos::kbd_backlight". This makes sense to me too. I'll send out a patch fixing this. > > > > > What is wilco, anyway? > > Wilco is a new Chrome OS device which does not use the same embedded > controller as the rest of the Chrome OS ecosystem. Thus, we need this new > driver because the old one will not be compatible. > > > > > Pavel > > -- > > (english) http://www.livejournal.com/~pavelmachek > > (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
